OK, approved.
-phil
On 1/24/20, 12:48 AM, Sergey Bylokhov wrote:
On 1/22/20 4:59 pm, Philip Race wrote:
The CSR will be necessary if I'll add or remove some assertions in
the spec.
Meaning you don't think it is currently needed ?
Yes, but I can create one if you think the changes are big enough.
Although really I don't understand how this fix is of any great
importance.
Who was having a problem with the existing behaviour / spec ?
The spec change wasn't an initial goal for this fix.
I have started from updating the implementation of the methods where we
inconsistently use fields and getters, then clean the methods which mix
different types of string concatenations, and since I already updated
most
of the methods I decided to cleanup the spec as well.
BTW this change made java.desktop.jmod smaller by 1kb
-phil.
On 1/12/20 12:14 PM, Sergey Bylokhov wrote:
Hello.
Please review a "weekend cleanup" for JDK 15.
Bug: https://bugs.openjdk.java.net/browse/JDK-8236980
Fix: http://cr.openjdk.java.net/~serb/8236980/webrev.00
I have made these changes:
- The words in the specs are unified across the different methods
- All toString() implementations now use getXXX() methods instead
of direct access to the fields(the getxxx() methods are skipped
only if the getxxx() method is final)
- A few tests were added to check some spec, and its implementations
