In article <20090717053517.ga10...@netbsd.org>, David Holland <dholland-sourcechan...@netbsd.org> wrote: >On Thu, Jul 16, 2009 at 10:18:09AM -0400, Christos Zoulas wrote: > > Modified Files: > > src/sys/arch/amd64/amd64: trap.c > > > > Log Message: > > handle protection fault properly. > >Shouldn't the non-DIAGNOSTIC default case set ksi_signo to something >other than 0? I'm not entirely sure what trapsignal will do with >signal 0, but I doubt it's the right thing.
Well, if you fall in the default case in both switch statements it is clearly a bug (because you added another case in the outside switch and you forgot to add it in the inside). I could remove the DIAGNOSTIC check, but that leads to bloat. christos
