I've defflag'd KDTRACE_HOOKS - it will stay either way with or without stubs.

Cheers,
Darran.
On 22/02/2010, at 1:56 AM, Quentin Garnier wrote:

On Sun, Feb 21, 2010 at 05:31:31AM +0000, Mindaugas Rasiukevicius wrote:
Quentin Garnier <c...@cubidou.net> wrote:
On Sun, Feb 21, 2010 at 02:11:40AM +0000, Darran Hunt wrote:
Module Name:    src
Committed By:   darran
Date:           Sun Feb 21 02:11:40 UTC 2010

Modified Files:
        src/sys/arch/i386/i386: trap.c vector.S
        src/sys/kern: kern_lwp.c kern_proc.c kern_synch.c
        src/sys/sys: lwp.h proc.h
Added Files:
        src/sys/sys: dtrace_bsd.h

Log Message:
Add the DTrace hooks to the kernel (KDTRACE_HOOKS config option).

Please defflag that option in conf/files and use the resulting include
file as necessary.

I think these #ifdefs for KDTRACE_HOOKS should be removed and empty stubs provided for no-DTrace case. Code will get cleaner and perhaps more modular.

It's a different debate.  If KDTRACE_HOOKS stays, it has to be
defflag'd.

--
Quentin Garnier - c...@cubidou.net - c...@netbsd.org
"See the look on my face from staying too long in one place
[...] every time the morning breaks I know I'm closer to falling"
KT Tunstall, Saving My Face, Drastic Fantastic, 2007.

Reply via email to