[reposting, was sent to s-c first] > Module Name: src > Committed By: dyoung > Date: Mon Mar 22 22:30:58 UTC 2010 > Modified Files: > src/sys/dev/isa: isadma.c pcdisplay.c > Log Message: > [...] > pcdisplay.c: #if 0 some code that compares two bus_space_tag_t's > in order to see if pcdisplay0 is console. It does not seem to > be helpful to compare the tags; maybe the author intended to > compare some other bus property?
What you are doing is rather destructive. This is not about bus properties but to find out whether a specific device is the same (which means it is located at the same base address) as the console device which was established before all the device tree. A base address is defined by a tag-handle tuple. MI code needs to be able to check for equality at least. This has been fine all the time -- what are you trying to accomplish? Even if you turn the tag into a pointer, it should be fine for MI code to compare this to other tags. best regards Matthias ------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------ Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender), Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Sebastian M. Schmidt ------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------