On Thu, Mar 18, 2010 at 1:12 AM, Masao Uebayashi <uebay...@tombi.co.jp> wrote: > On Tue, Mar 16, 2010 at 03:52:26AM +0000, YAMAMOTO Takashi wrote: >> > Why not adding VOP_GETPAGES_XIP - because XIP is almost transparent to >> > filesystems. The difference between XIP or not is only where to get pages, >> > which is beyond filesystem's task. >> >> it doesn't sound convincing to me, given that you have a separate copy >> of genfs_getpages for xip. > > My intent is to merge it into genfs_getpages(). But that'll involve changes > to genfs_getpages(), and it's beyond my scope at the moment. I put comments > to reflect my intent that I want to merge two copies. > > I hope this answers your questions.
I'd also point out that genfs_io.c already has two copies of genfs_do_io() (itself and in genfs_getpages()). I'd want to merge these two first, but this is beyond the XIP branch. Merging these two + _getpages_xip() will be done very slowly in the future... Masao
