On 18.04.2011 09:23, Cherry G. Mathew wrote:
> On 18 April 2011 08:00, Cherry G. Mathew <cherry.g.mat...@gmail.com> wrote:
>> On 18 April 2011 04:21, Mindaugas Rasiukevicius <rm...@netbsd.org> wrote:
>>> Masao Uebayashi <uebay...@tombi.co.jp> wrote:
>>>> On Mon, Apr 18, 2011 at 03:04:32AM +0000, Mindaugas Rasiukevicius wrote:
>>>>> Module Name:        src
>>>>> Committed By:       rmind
>>>>> Date:               Mon Apr 18 03:04:31 UTC 2011
>>>>> Modified Files:
>>>>>     src/sys/arch/xen/xen: balloon.c
>>>>> Log Message:
>>>>> balloon_xenbus_attach: use KM_SLEEP for allocation.
>>>>> Note: please do not use KM_NOSLEEP.
>>>> And, according to yamt@, KM_SLEEP can fail in the current design...
>>> IIRC yamt@ fixed it a year or few ago.
>> And in the more specific immediate context:
>> http://mail-index.netbsd.org/port-xen/2011/04/07/msg006613.html
> PS: Can you please revert ? Unless it's breaking anything else, or you
> have a fix for the problem mentioned in the thread above, ie;

Uho, I forgot to mention in my commit log that I fixed it. I am
allocating bpg_entries via pool_cache(9), and the constructor
bpge_ctor() will return an error if uvm(9) fails to find a free page. In
that case, the thread will just bail out and start waiting again.

Jean-Yves Migeon

Reply via email to