On Thu, May 26, 2011 at 07:12:57AM +0000, David Holland wrote: > On Wed, May 25, 2011 at 04:33:38PM +0000, Masao Uebayashi wrote: > > Modified Files: > > src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c > > src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c > > > > Log Message: > > Declare cfdrivers using extern rather than including ioconf.h. > > This is wrong. Please revert it. > > The purpose of declaring things in header files is to make sure all > uses are consistent.
Is there another header file that could contain: #define CFDRIVER(prefix) extern struct cfdriver prefix##_cd Then the bcsp.h could contain: CFDRIVER(bcsp); which gives (effectively) the same guarantee as including ioconf.h. I think something like that would help building drivers as kernel modules. David -- David Laight: da...@l8s.co.uk