On Sat, 4 Jun 2011, Jukka Ruohonen wrote:
On Sat, Jun 04, 2011 at 01:24:33PM +0000, Paul Goyette wrote:
Since nothing actually records or maintains an average sensor value,
remove value_avg from the prop_dict. We can't completely remove it
because there's one driver that uses this field for its own private
purposes, so for now we just rename the member.
Wouldn't it be better to just modify the (apparently misbehaving) driver
instead of harness the whole KPI for one quirk?
Yes, that driver will be modified. It is dev/pci/arcmsr.c that does the
abuse. Unfortunately there is more abuse in that driver, so clean-up
will take a little bit longer.
Note that when that modification does happen, it will require a version
bump, since the ABI for sensor modules will have changed.
-------------------------------------------------------------------------
| Paul Goyette | PGP Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-------------------------------------------------------------------------
