On Wed, Nov 30, 2011 at 01:13:10PM -0500, Christos Zoulas wrote:
> On Nov 30, 12:13pm, bou...@antioche.eu.org (Manuel Bouyer) wrote:
> -- Subject: Re: CVS commit: src/sys/dev
> 
> | This is not going to be used outside of fss.c so I'm not sure what this 
> would
> | give us ...
> 
> Keeps the headers tidy, and it will make it easy in the future to delete
> compatibility code. I would also move the compat code somewhere too,
> and call a function around it:
> 
> default:
> #ifdef COMPAT_50
>       error = fss_compat_ioctl(...);
> #else
>       error = EINVAL;
> #endif
> }

This will duplicate more code 

-- 
Manuel Bouyer <bou...@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Reply via email to