On Dec 23, 2:20pm, chacon.ja...@gmail.com (James Chacon) wrote: -- Subject: Re: CVS commit: src/sys/netinet
| Unfortunately pfctl references them if it sees ICMP_PHOTURIS defined. Ah. | A quick search for these does show a lot of use out there between | *BSD, linux, etc. | | And http://www.iana.org/assignments/icmp-parameters/icmp-parameters.xml#icm= | p-parameters-codes-40 | shows a few more even and RFC2521 seems to be defining all of this. | | BTW: What happens if icmp_error gets something above ICMP_MAX_TYPE in? | It appears we hard panic: | | if ((u_int)type > ICMP_MAXTYPE) | panic("icmp_error"); | The code wil not generate them, so there will be no panic. Changing ICMP_MAXTYPE to be > 18 will require us re-doing the ICMP stats... I am not prepared to do this yet. It will lead to binary incompatibility with netstat. christos
