On Wed, Jun 05, 2013 at 19:53:09 -0400, Christos Zoulas wrote: > On Jun 5, 4:18pm, g...@ir.bbn.com (Greg Troxel) wrote: > -- Subject: Re: CVS commit: src/sys > > | Index: src/sys/netinet/tcp_input.c > | diff -u src/sys/netinet/tcp_input.c:1.325 src/sys/netinet/tcp_input.c:1.326 > | --- src/sys/netinet/tcp_input.c:1.325 Fri Jun 22 15:09:36 2012 > | +++ src/sys/netinet/tcp_input.c Wed Jun 5 19:01:26 2013 > | @@ -3421,11 +3417,7 @@ > | tcp_fields_to_host(th); > | if (sav == NULL) > | return (-1); > | -#ifdef FAST_IPSEC > | - KEY_FREESAV(&sav); > | -#else > | - key_freesav(sav); > | -#endif > | + KEY_FREESAV(sav); > | return (-1); > | } > | tcp_fields_to_host(th); > | > | which looks like either a logic bug or something that won't build (note > | disappearing &in argument to KEY_FREESAV. Did this pass a build.sh > | release? > | --=-=-= > > It did build for me, strange.
Are you building ALL? options TCP_SIGNATURE is not in GENERIC, and this code is #ifdef'ed on it. -uwe
