On Thu, Jul 04, 2013 at 08:51:09AM +0100, Nick Hudson wrote:
> On 06/23/13 03:35, Taylor R Campbell wrote:
> >+ * rndsink_request takes a spin lock at IPL_VM, so we can be no
> >+ * higher than that.
> >+ */
> >+ KASSERT(ipl <= IPL_VM);
>
> Hi,
>
> This isn't always the case as some platforms have a different
> ordering for IPL levels.
>
> How about
>
> KASSERT(ipl != IPL_SCHED && ipl != IPL_HIGH)
>
> although this was suggsted as well
>
> KASSERT(IPL_SCHED > IPL_VM ? ipl <= IPL_VM : ipl >= IPL_VM);
Are we sure that all platforms use strictly-ordered integers for ipl ?
I could immagine using bitmasks as IPL values for example ...
--
Manuel Bouyer <bou...@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--
