On Thu, Jul 04, 2013 at 14:56:17 +0300, Antti Kantee wrote: > On 4.7.2013 14:53, Valery Ushakov wrote: > >On Thu, Jul 04, 2013 at 10:14:04 +0000, Antti Kantee wrote: > > > >>Module Name: src > >>Committed By: pooka > >>Date: Thu Jul 4 10:14:04 UTC 2013 > >> > >>Modified Files: > >> src/sys/rump: Makefile.rump > >> > >>Log Message: > >>Apparently warning flags are not kept in CWARNFLAGS. Compensate. > > > >Would you care to elaborate? Do you refer to the fact that bsd.sys.mk > >adds -Werror to CFLAGS instead of CWARNFLAGS? > > > >CFLAGS+= ${${_NOWERROR} == "no" :?-Werror:} ${CWARNFLAGS} > > That and this: > > .if ${WARNS} > 1 > CFLAGS+= -Wreturn-type -Wswitch -Wshadow > .endif > .if ${WARNS} > 2 > CFLAGS+= -Wcast-qual -Wwrite-strings > CFLAGS+= -Wextra -Wno-unused-parameter > # Readd -Wno-sign-compare to override -Wextra with clang > CFLAGS+= -Wno-sign-compare > [...]
Ah, I was confused because just before that I was staring at FreeBSD bsd.sys.mk which does use CWARNFLAGS for -W* and then looked at -Werror in ours. History says: revision 1.26 date: 1998-08-25 18:57:21 +0400; author: tv; state: Exp; lines: +3 -2; Introduce CWARNFLAGS, idea from kernel Makefiles, which goes after "-Wall ..." in the CFLAGS and can be set in directory Makefile or mk.conf. incidentally, the reason I was looking at FreeBSD bsd.sys.mk was precisely that I needed to disable one of the warning options but they append them to CWARNFLAGS overriding your settings instead. -uwe