> Module Name:  src
> Committed By: palle
> Date:         Tue Jan  7 20:11:35 UTC 2014
> Modified Files:
>       src/sys/arch/sparc64/include: cpu.h sparc64.h
>       src/sys/arch/sparc64/sparc64: cpu.c genassym.cf locore.s ofw_machdep.c
>           pmap.c
> Log Message:
> sun4v: trap table setup - currently populated with dummy entries which
> will be properly implemented later - parts from OpenBSD - OK martin@


thanks for working on this.  looks pretty good.  there are a couple of
minor things i'd like seen cleaned up here:

+ #ifdef SUN4V
+       /* MMU Fault Status Area. Will be initialized to the physical
+          address of the bottom of the interrupt stack */
+       paddr_t                 ci_mmfsa;
+ #endif

in struct cpu_info -- please make it always present, so that struct
cpu_info doesn't change size/placement/etc.  this also makes it more
possible to have modules shared between sun4u and sun4v (we just have
to make sure everything is accessed via a function if it isn't

+       if ( CPU_ISSUN4V )

please remove the extra spaces around the macro in a couple of places.



Reply via email to