On Mon, Aug 18, 2014 at 07:14:46AM -0700, Chuck Silvers wrote: > On Mon, Aug 18, 2014 at 04:49:17AM +0000, Christos Zoulas wrote: > > In article <20140817230358.6b94...@cvs.netbsd.org>, > > Chuck Silvers <source-changes-d@NetBSD.org> wrote: > > >-=-=-=-=-=- > > > > > >Module Name: src > > >Committed By: chs > > >Date: Sun Aug 17 23:03:58 UTC 2014 > > > > > >Modified Files: > > > src/sys/kern: exec_elf.c > > > > > >Log Message: > > >eliminate COMPAT_OLDNOTE and just always recognize the old notes. > > > > I don't think I like this, because it allows for sloppy note handling. > > If we had this code, we would have not found the incorrect note handling > > in "go". If I don't care about running old binaries, I should expect to > > have correct notes. > > my interpretation of our earlier email discussion was that the old notes > were correct and treating them the same as the current notes was fine, > but the current exec code was being overly strict by calling them invalid. > the difference in to code to honor them or not is "<" vs. "!=", > so there seemed no harm in doing it all the time. > > I'm not aware of the issue with "go", could you explain?
https://code.google.com/p/go/source/detail?spec=svnb86ee06ef235d5766845f44056f152e1808da110&r=59a0284a32de10811abce538b94f97418d10561d --- begin quote --- cmd/ld: correctly compute note size on NetBSD. Patch from http://gnats.NetBSD.org/48811. LGTM=iant R=golang-codereviews, minux.ma, iant CC=golang-codereviews, tk https://codereview.appspot.com/94670047 Committer: Ian Lance Taylor <i...@golang.org> --- end quote --- Thomas