Date:        Mon, 6 Oct 2014 14:26:44 +0000
    From:        "Havard Eidnes" <h...@netbsd.org>
    Message-ID:  <20141006142644.7693...@cvs.netbsd.org>

  | Make this build again without debugging enabled; DPRINTF() can end up
  | as empty, and in an if conditional, you then need braces if that's the
  | only potential body.

That change makes no sense to me - the original code was

        if (error)
                DPRINTF((....));

and even if DPRINTF() could produce nothing, the result would be

        if (error)
                ;

which is perfectly good C (useless, but acceptable).  Adding { } around
the ';' changes nothing.

But in any case, apb changed it yesterday, so DPRINTF() never produces
nothing (personally I'm not sure that should have been needed, but that's
beside the point).

What was the error that resulted in the addition of the {} ?

lre

Reply via email to