On Wed, Apr 1, 2015 at 5:50 AM, Christoph Badura <b...@bsd.de> wrote: > On Tue, Mar 31, 2015 at 11:09:02AM +0900, Ryota Ozaki wrote: >> On Tue, Mar 31, 2015 at 1:42 AM, Matt Thomas <m...@3am-software.com> wrote: >> > It lacks compensating for the fact the CRC has been stripped by the >> > time vlan gets the packet. >> >> # matt@ explained well than me... >> >> Note that the issue was found by some strict packet capture software >> (not by me, so I don't know what it is); typical OSes don't complain >> the extra padding, so we didn't notice the issue until recently. > > Yeah. I misunderstood your message in the PR. I read it as if > if_vlan.c should be sending 72 byte minimum size packets and the code > was doing something different. That's why I asked. > > Maybe we should update the PR.
Updated! ozaki-r