On 2015/04/04 06:33, Nick Hudson wrote:
Module Name: src
Committed By: skrll
Date: Fri Apr 3 21:33:23 UTC 2015
Modified Files:
src/sys/dev/usb [nick-nhusb]: uhci.c
Log Message:
Various readability changes.
#ifdef DIAGNOSTIC -> KASSERT / __diagused
@@ -3151,10 +3105,8 @@ uhci_device_ctrl_done(struct usbd_xfer *
KASSERT(sc->sc_bus.ub_usepolling || mutex_owned(&sc->sc_lock));
UHCIHIST_FUNC(); UHCIHIST_CALLED();
-#ifdef DIAGNOSTIC
- if (!(xfer->ux_rqflags & URQ_REQUEST))
- panic("uhci_device_ctrl_done: not a request");
-#endif
+
+ KASSERT(!(xfer->ux_rqflags & URQ_REQUEST));
if (!uhci_active_intr_info(ii))
return;
It seems logic is inverted.
--
t-hash
