On 2015/06/14 5:42, Christos Zoulas wrote: > In article <20150613154758.6971...@cvs.netbsd.org>, > SAITOH Masanobu <source-changes-d@NetBSD.org> wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By: msaitoh >> Date: Sat Jun 13 15:47:58 UTC 2015 >> >> Modified Files: >> src/sys/dev/pci: if_wm.c if_wmreg.h >> >> Log Message: >> Add MSI/MSI-X support written by Kengo Nakahara. Some old devices' support >> is written by me. It's disabled by default. If you'd like to use, define >> WM_MSI_MSIX. >> >> Tested with: >> 8254[3405617] (INTx even if it has MSI CAP because of a errata) >> 8257[12], 82583 ICH8, ICH10, PCH2, PCH_LPT(I21[78]) (MSI) >> 8257[456], 82580, I35[04], I21[01] (MSI-X) >> >> Not tested: >> 82542, 82573, 80003, ICH9, PCH, >> > > I had raised quite a few issues about calcifying this interrupt API, > also copying the code 3 times... > > christos
I thought it's not required to wait API was fixed and committed. To support only MSI is easy, but MSI-X is not. This commit includes not only pci_intr_establish() stuff but also include other MSI-X stuff to setup MSI-X vector table and interrupt related functions. And, it'll take time to check regression or stability to make it enable by default, so it's important other people to test with it. The same work will be required for RAID controllders' drviers. Thanks. -- ----------------------------------------------- SAITOH Masanobu (msai...@execsw.org msai...@netbsd.org)