In article <20151102010615.a199...@cvs.netbsd.org>, Kamil Rytarowski <source-changes-d@NetBSD.org> wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kamil >Date: Mon Nov 2 01:06:15 UTC 2015 > >Modified Files: > src/lib/libpanel: above.c bottom.c del.c hidden.c new.c panel.h > panel_impl.h replace.c show.c top.c window.c > >Log Message: >No functional changes > >Make this code nicer for C++ compilers, don't assign char* to void*. >Add extra __prefix_false() CPU hint for failed malloc(3). >Normalize whitespace.
The blank line at the beginning of functions that don't contain declarations is part of style... I am not enamored by it, but it is what it is. As far as casts go, the casts that cast from void * to other types (return of malloc) should go. This is not c++ (and if it was meant to be compiled for c++ it should be using modern c++ casts) because casting malloc only hides the fact that you forgot to include <stdlib.h>... christos
