> Date: Fri, 21 Apr 2017 17:47:22 +0000 > From: co...@sdf.org > > /home/source/ab/HEAD-llvm/src/sbin/fsck_ext2fs/pass1.c:242:39: warning: > comparison of array 'dp->e2di_blocks' equal to a null pointer is always false > [-Wtautological-pointer-compare] > (EXT2_MAXSYMLINKLEN == 0 && dp->e2di_blocks == 0)) { > ~~~~^~~~~~~~~~~ ~
I am pretty sure this was supposed to be dp->ed2i_nblock, not vacuously true. Compare the analogous code in fsck_ffs/pass1.c, with the same comment over it.