On Sun, Sep 10, 2017 at 01:18:07PM +0200, Maxime Villard wrote: > Le 06/09/2017 à 14:39, Manuel Bouyer a écrit : > > Module Name: src > > Committed By: bouyer > > Date: Wed Sep 6 12:39:18 UTC 2017 > > > > Modified Files: > > src/sys/arch/amd64/amd64: gdt.c > > src/sys/arch/i386/i386: gdt.c > > > > Log Message: > > The last GDT slots are reserved for Xen, so use FIRST_RESERVED_GDT_BYTE > > instead of MAXGDTSIZ for gdt_size. > > Xen kernels should boot again. > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.41 -r1.42 src/sys/arch/amd64/amd64/gdt.c > > cvs rdiff -u -r1.66 -r1.67 src/sys/arch/i386/i386/gdt.c > > > > Please note that diffs are not public domain; they are subject to the > > copyright notices on the relevant files. > > While I'm at it: is it normal that in amd64::lgdt() we're calling > xpmap_ptetomach with a pte and not a va?
it is a VA (it's a pointer to a pte, not the pte iself) > And is it normal that in > i386::gdt_init_cpu() we're not using a mask on the pte when doing > [*ptp >> PAGE_SHIFT]? Why should it be masked ? -- Manuel Bouyer <bou...@antioche.eu.org> NetBSD: 26 ans d'experience feront toujours la difference --