On Fri, Oct 27, 2017 at 09:59:17 +0000, Utkarsh Anand wrote: > syzkaller was failing to extract constants because of the above > mentioned issue so I had to redeclare printf in sys/sys/systm.h
Was this ever discussed anywhere or even reviewed by your sponsor? It doesn't make me comfortable when someone's first commit changes kernel printf() w/out discussion or approval. To me this looks like a syzkaller bug. The error message doesn't even say where the conflicting declaration is coming from. If they are assuming printf must return int, they are assuming wrong b/c the kernel is a "freestanding" environment and <stdio.h> is not part of it. -uwe