On 24.03.2018 16:47, Martin Husemann wrote: > On Sat, Mar 24, 2018 at 09:38:15AM +0100, Thomas Klausner wrote: >> On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote: >>> On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote: >>> >>>> I had to revert this in order to unbreak build. >>> >>> >>> Please never do that. >> >> I think it's appropriate if it's a small patch that breaks the build >> and can easily be backed out without side effects. > > IIRC the official way is: > > - ping the commiter and notify them of the problem > - give a bit of time (like 24h or so) > - invoke core to revert the commit > > See commit guidelines point 11: > > Do not revert other developer's commits. > > If you do not agree with another developer's > commit, do not revert it on your own. Contact the > other developer and explain to him or her the > issues you have with the commit in question. Ask > the other developer to back out the changes > instead of doing it yourself. > > Martin >
Thanks! I was trying to reach developers yesterday twice and get feedback what to do, but no echo was received. It was almost a whole-day breakage. Next time I will try with a mail.
signature.asc
Description: OpenPGP digital signature
