On Fri, Apr 20, 2018 at 11:12:41PM +0000, Christos Zoulas wrote: > In article <20180420213017.ga1...@antioche.eu.org>, > Manuel Bouyer <bou...@antioche.eu.org> wrote: > >On Fri, Apr 20, 2018 at 05:03:00PM -0400, Christos Zoulas wrote: > >> Module Name: src > >> Committed By: christos > >> Date: Fri Apr 20 21:03:00 UTC 2018 > >> > >> Modified Files: > >> src/sys/dev/usb: if_axe.c > >> > >> Log Message: > >> It was not gcc's fault for correctly detecting an uninitialized variable. > >> Fix the uninitialized variable issues by error checking things. > > > >@@ -507,7 +511,7 @@ > > ifp->if_flags &= ~IFF_ALLMULTI; > > rxmode |= AXE_RXCMD_MULTICAST; > > > >- axe_cmd(sc, AXE_CMD_WRITE_MCAST, 0, 0, (void *)&hashtbl); > >+ axe_cmd(sc, AXE_CMD_WRITE_MCAST, 0, 0, hashtbl); > > > >missing & ? > > uint8_t hashtbl[8] = { 0, 0, 0, 0, 0, 0, 0, 0 };
So I guess the code was wrong before; not sure how multicast could have worked. Does this requires pullups ? -- Manuel Bouyer <bou...@antioche.eu.org> NetBSD: 26 ans d'experience feront toujours la difference --