In article <20180715143050.ga28...@britannica.bec.de>, Joerg Sonnenberger <jo...@bec.de> wrote: >On Sat, Jul 14, 2018 at 08:36:13PM -0400, Christos Zoulas wrote: >> Module Name: src >> Committed By: christos >> Date: Sun Jul 15 00:36:13 UTC 2018 >> >> Modified Files: >> src/sys/arch/arm/include: int_fmtio.h >> >> Log Message: >> Fix formats for gcc where int64 is long not long long (like clang which >> should be changed). > >As I said before, this patch is wrong. Clang will never hit the >definitions anyway.
The patch is written this way to conservatively preserve the existing behavior on aarch64 with clang. Once clang is fixed to not use long long for int64, I will fix it. Of course it would have been easier for me to remove the few lines in clang that cause this, but you are not allowing it. Instead, I have to patch openssl, create this mess and at the same time cause a flag day later when the port is more mature which is undesirable. Things like this should be fixed sooner than later. christos
