On 2018/08/19 1:11, Jason Thorpe wrote:
On Aug 18, 2018, at 8:49 AM, Rin Okuyama <rokuy...@rk.phys.keio.ac.jp> wrote:
...
"ifdef" statements refer "attrtab", whose entries are not normalized to
lower-case. Therefore, "ifdef arm32" becomes false even if we have
"options ARM32", as I wrote in the previous message:
http://mail-index.netbsd.org/source-changes-d/2018/08/18/msg010463.html
Well, this is a very confusing behavior of config(1). We should normalize
everything to lower-case, provided no one depends on this behavior...
Well, interestingly enough, this works (of course):
# files common to arm32 implementations
file arch/arm/arm32/arm32_machdep.c arm32
file arch/arm/arm32/bus_dma.c arm32
.
.
.
I'm a little confused why "ifdef" would reference the attrtab, though...it
seems like it should be looking at the options / flags table. (It's been a long time
since I was deep in the bowels of config(1), though, so entirely possible that something
drastic has changed while I wasn't paying attention...)
Well, config(1) has too many tables that have similar roles.
This problem was pointed in usr.bin/config/TODO:
https://nxr.netbsd.org/xref/src/usr.bin/config/TODO#344
Overhaul should be made by someone sometime ;-), although it
must be a tough work that affects too wide a range...
rin
