Sorry, I didn't check whether the module gets compiled.
Thanks,
rin
On 2018/12/12 1:45, Martin Husemann wrote:
Module Name: src
Committed By: martin
Date: Tue Dec 11 16:45:49 UTC 2018
Modified Files:
src/sys/dev/usb: if_mue.c
Log Message:
Avoid signed/unsigned comparision (if_mtu is uint64_t)
To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/usb/if_mue.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/usb/if_mue.c
diff -u src/sys/dev/usb/if_mue.c:1.22 src/sys/dev/usb/if_mue.c:1.23
--- src/sys/dev/usb/if_mue.c:1.22 Tue Dec 11 13:35:02 2018
+++ src/sys/dev/usb/if_mue.c Tue Dec 11 16:45:49 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: if_mue.c,v 1.22 2018/12/11 13:35:02 rin Exp $ */
+/* $NetBSD: if_mue.c,v 1.23 2018/12/11 16:45:49 martin Exp $ */
/* $OpenBSD: if_mue.c,v 1.3 2018/08/04 16:42:46 jsg Exp $ */
/*
@@ -20,7 +20,7 @@
/* Driver for Microchip LAN7500/LAN7800 chipsets. */
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.22 2018/12/11 13:35:02 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.23 2018/12/11 16:45:49 martin Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -1218,7 +1218,8 @@ mue_encap(struct mue_softc *sc, struct m
M_CSUM_TCPv6 | M_CSUM_UDPv6);
len = m->m_pkthdr.len;
- if (__predict_false((!tso && len > MUE_FRAME_LEN(ifp->if_mtu)) ||
+ if (__predict_false((!tso &&
+ (unsigned)len > MUE_FRAME_LEN(ifp->if_mtu)) ||
( tso && len > MUE_TSO_FRAME_LEN))) {
MUE_PRINTF(sc, "packet length %d\n too long", len);
return EINVAL;
