Yeah, I told Martin already, but he had to go to bed. Stupid global
project. :)
On Wed, 2 Jan 2019, Tom Spindler (moof) wrote:
This breaks the netbsd-8 build:
dependall ===> lib/libc
# compile libc/compat___msgctl13.o
/usr/obj/8tools/bin/x86_64--netbsd-gcc -O2 -std=gnu99 -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare
-Wsystem-headers -Wno-traditional -Wa,--fatal-warnings -Wreturn-type
-Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter
-Wno-sign-compare -Wold-style-definition -Wsign-compare -Wformat=2
-Wno-format-zero-length -Werror -fPIE -fstack-protector -Wstack-protector
--param ssp-buffer-size=1 --sysroot=/usr/obj/8dd -D_LIBC -DLIBC_SCCS
-DSYSLIBC_SCCS -D_REENTRANT -DHESIOD -DINET6 -DNLS -DYP
-I/src/nb8src/lib/libc/include -I/src/nb8src/lib/libc -I/src/nb8src/sys
-I/src/nb8src/lib/libc/compat/../locale -I/src/nb8src/lib/libc/compat/stdlib
-I/src/nb8src/lib/libc/compat/../stdlib -D__BUILD_LEGACY
-I/src/nb8src/lib/libc/../../common/lib/libc/quad
-I/src/nb8src/lib/libc/../../common/lib/libc/string
-I/src/nb8src/lib/libc/../../common/lib/libc/arch/x86_64/string
-D__DBINTERFACE_PRIVATE -I/src/nb8src/libexec/ld.elf_so -I/
src/nb8src/lib/libc/dlfcn -I/src/nb8src/lib/libc/gdtoa
-I/src/nb8src/lib/libc/locale -DNO_FENV_H
-I/src/nb8src/lib/libc/arch/x86_64/gdtoa -DWITH_RUNE -I/src/nb8src/lib/libc
-DPOSIX_MISTAKE -DCOMPAT__RES -DUSE_POLL -DPORTMAP -DWIDE_DOUBLE -DALL_STATE
-DUSG_COMPAT -D_FORTIFY_SOURCE=2 -c
/src/nb8src/lib/libc/compat/sys/compat___msgctl13.c -o compat___msgctl13.o
In file included from /src/nb8src/lib/libc/compat/sys/compat___msgctl13.c:48:0:
/src/nb8src/sys/compat/sys/msg.h: In function '__native_to_msqid_ds13':
/src/nb8src/sys/compat/sys/msg.h:111:2: error: implicit declaration of function
'memset' [-Werror=implicit-function-declaration]
memset(omsqbuf, 0, sizeof(*omsqbuf));
^
/src/nb8src/sys/compat/sys/msg.h:111:2: error: incompatible implicit
declaration of built-in function 'memset' [-Werror]
/src/nb8src/sys/compat/sys/msg.h:111:2: note: include '<string.h>' or provide a
declaration of 'memset'
/src/nb8src/sys/compat/sys/msg.h: In function '__native_to_msqid_ds14':
/src/nb8src/sys/compat/sys/msg.h:153:2: error: incompatible implicit
declaration of built-in function 'memset' [-Werror]
memset(omsqbuf, 0, sizeof(*omsqbuf));
^
/src/nb8src/sys/compat/sys/msg.h:153:2: note: include '<string.h>' or provide a
declaration of 'memset'
On Wed, Jan 02, 2019 at 03:51:31PM +0000, Martin Husemann wrote:
Module Name: src
Committed By: martin
Date: Wed Jan 2 15:51:31 UTC 2019
Modified Files:
src/sys/compat/netbsd32 [netbsd-8]: netbsd32_compat_14.c
netbsd32_conv.h
src/sys/compat/sys [netbsd-8]: msg.h
Log Message:
Pull up following revision(s) (requested by maxv in ticket #1151):
sys/compat/netbsd32/netbsd32_conv.h: revision 1.37
sys/compat/netbsd32/netbsd32_compat_14.c: revision 1.27
sys/compat/sys/msg.h: revision 1.5
Fix kernel info leaks.
+ Possible info leak: [len=80, leaked=10]
| #0 0xffffffff80bad7a7 in kleak_copyout
| #1 0xffffffff8048e71b in netbsd32___msgctl50
| #2 0xffffffff8022fb5b in netbsd32_syscall
| #3 0xffffffff802096dd in handle_syscall
To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.26.10.1 src/sys/compat/netbsd32/netbsd32_compat_14.c
cvs rdiff -u -r1.31.8.1 -r1.31.8.2 src/sys/compat/netbsd32/netbsd32_conv.h
cvs rdiff -u -r1.4 -r1.4.58.1 src/sys/compat/sys/msg.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
--
Hisashi T Fujinaka - ht...@twofifty.com
BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee