Re: CVS commit: src/sys/dev/ic

[Nick Hudson]

On 30/05/2019 21:46, matthew green wrote:

Committed By:   tnn
Date:           Thu May 30 07:37:17 UTC 2019

Modified Files:
        src/sys/dev/ic: ssdfb.c

Log Message:
- include uvm.h before uvm_device.h
- don't need IPL_SCHED here

the IPL_SCHED change seems backwards to me.

IPL_VM is the "this driver is not updated to MPSAFE yet" level,
but IPL_SCHED is the MPSAFE level.

ie, we should be striving to remove any uses of IPL_VM, not
moving (back) to them.

In my view we should be using IPL_VM + IST_MPSAFE (and not IPL_SCHED) if
the driver is MPSAFE.

Nick