On Fri, Jun 28, 2019 at 05:03:37AM -0700, Jason Thorpe wrote:
> > On Jun 26, 2019, at 7:10 PM, matthew green <m...@eterna.com.au> wrote:
> > 
> >> Always include the 32 bit structure and definitions on _LP64 regardless
> >> of compat32 being on or off, because we want the headers to work when
> >> compiling modular kernels. Of course the 32 bit structs do not make sense
> >> on platforms that don't have 32 bit modes (alpha), but we don't have
> >> a define for that and it does not hurt.
> > 
> > i've been using _LP64 && !__alpha__ for this when it strikes.
> > 
> > sub-optimal, but also easy to grep and find :-)
> Perhaps we should define "_LP64_ONLY" in <machine/types.h> for this type of 
> situation?

I'm a really huge fan of keeping structs the same across archs when it
doesn't cost us very much.

It's been a real blessing that netbsd is mostly consistent when porting
programming languages, which often end up embedding a list of structs
and their sizes, generated by very fragile code (or by hand!)

Reply via email to