On Thu, Oct 03, 2019 at 22:09:28 -0400, Christos Zoulas wrote: > Thanks, and zero is special for 0#. Should I revert it?
Yes, please. > > On Oct 3, 2019, at 10:06 PM, Valery Ushakov <u...@stderr.spb.ru> wrote: > > > > > >> Modified Files: > >> src/sys/arch/acorn32/acorn32: rpc_machdep.c > >> > >> Log Message: > >> change 0x% -> %x > > > > This should read %#x. > > And this is wrong. > > > > 1) With # the 0x is part of the width, so > > > > 0x%08x -> 0x00000001 > > %#08x -> 0x000001 > > > > 0x00000000 0x00000001 > > 00000000 0x000001 > > > > 2) # doesn't add prefix for zero, so > > > > 0x%08x -> 0x00000000 > > %#08x -> 00000000 -uwe