Module Name:    src
Committed By:   mrg
Date:           Fri Oct  4 09:47:28 UTC 2019

Modified Files:
        src/external/bsd/file/lib: Makefile
        src/external/bsd/llvm/lib/libLLVMCodeGen: Makefile
        src/external/bsd/ntp/bin/ntp-keygen: Makefile
        src/external/bsd/ntp/bin/ntpd: Makefile
        src/external/bsd/pkg_install/lib: Makefile
        src/external/mit/xorg/lib/libXext: Makefile
        src/usr.bin/tftp: Makefile
        src/usr.sbin/sysinst: Makefile.inc

Log Message:
turn off various warnings for various things:

- file has looks bogus maybe-uninitialized
- llvm triggers an attribute violation:
  ScheduleDAGInstrs.cpp:1430:14: error: declaration of
    'llvm::raw_ostream& llvm::operator<<(llvm::raw_ostream&, const 
llvm::ILPValue&)'
    with attribute 'noinline' follows inline declaration [-Werror=attributes]
- ntp and pkg_install have obvious restrict violations, should be
  fixed but i'm avoiding patching upstream code in this pass
- tftp has an array bounds that doesn't seem real issue
- sysinst's partman.c has major problem with passing the same
  string as source and dest in snprintf, as a way to strcat
  with formatting which trip restrict violations.  non trivial
  to fix so for now the warning is elided.
- Xext's XEVI.c has similar issue as partman.c

everyone and GCC 8 gets these warnings turned off for now:

        -Wno-format-truncation
        -Wno-stringop-overflow
        -Wno-stringop-truncation
        -Wno-cast-function-type

as they trip a large amount of code.  most of them should be
investigated, but the few i looked at were not finding actually
real bugs, vs instances of poor coding, so skipping for now.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/external/bsd/file/lib/Makefile
cvs rdiff -u -r1.34 -r1.35 src/external/bsd/llvm/lib/libLLVMCodeGen/Makefile
cvs rdiff -u -r1.5 -r1.6 src/external/bsd/ntp/bin/ntp-keygen/Makefile
cvs rdiff -u -r1.22 -r1.23 src/external/bsd/ntp/bin/ntpd/Makefile
cvs rdiff -u -r1.9 -r1.10 src/external/bsd/pkg_install/lib/Makefile
cvs rdiff -u -r1.8 -r1.9 src/external/mit/xorg/lib/libXext/Makefile
cvs rdiff -u -r1.11 -r1.12 src/usr.bin/tftp/Makefile
cvs rdiff -u -r1.23 -r1.24 src/usr.sbin/sysinst/Makefile.inc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/external/bsd/file/lib/Makefile
diff -u src/external/bsd/file/lib/Makefile:1.11 src/external/bsd/file/lib/Makefile:1.12
--- src/external/bsd/file/lib/Makefile:1.11	Wed Dec 12 06:36:13 2018
+++ src/external/bsd/file/lib/Makefile	Fri Oct  4 09:47:27 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.11 2018/12/12 06:36:13 msaitoh Exp $
+#	$NetBSD: Makefile,v 1.12 2019/10/04 09:47:27 mrg Exp $
 #
 
 USE_FORT?= yes	# data driven bugs?
@@ -41,4 +41,6 @@ magic.h:        magic.h.in
 	${TOOL_SED} -e "s/X.YY/${VERSION:S/.//g}/" < ${.ALLSRC} > ${.TARGET}
 CLEANFILES+=	magic.h
 
+CFLAGS+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-maybe-uninitialized :}
+
 .include <bsd.lib.mk>

Index: src/external/bsd/llvm/lib/libLLVMCodeGen/Makefile
diff -u src/external/bsd/llvm/lib/libLLVMCodeGen/Makefile:1.34 src/external/bsd/llvm/lib/libLLVMCodeGen/Makefile:1.35
--- src/external/bsd/llvm/lib/libLLVMCodeGen/Makefile:1.34	Tue Jul 17 18:55:27 2018
+++ src/external/bsd/llvm/lib/libLLVMCodeGen/Makefile	Fri Oct  4 09:47:27 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.34 2018/07/17 18:55:27 joerg Exp $
+#	$NetBSD: Makefile,v 1.35 2019/10/04 09:47:27 mrg Exp $
 
 LIB=	LLVMCodeGen
 
@@ -169,6 +169,10 @@ SRCS+=	AggressiveAntiDepBreaker.cpp \
 	WinEHPrepare.cpp \
 	XRayInstrumentation.cpp
 
+.if !defined(HOSTLIB)
+COPTS.ScheduleDAGInstrs.cpp+= ${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-attributes :}
+.endif
+
 .if defined(HOSTLIB)
 .include <bsd.hostlib.mk>
 # Crashes some versions of GCC

Index: src/external/bsd/ntp/bin/ntp-keygen/Makefile
diff -u src/external/bsd/ntp/bin/ntp-keygen/Makefile:1.5 src/external/bsd/ntp/bin/ntp-keygen/Makefile:1.6
--- src/external/bsd/ntp/bin/ntp-keygen/Makefile:1.5	Sat Dec 28 03:19:43 2013
+++ src/external/bsd/ntp/bin/ntp-keygen/Makefile	Fri Oct  4 09:47:28 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.5 2013/12/28 03:19:43 christos Exp $
+#	$NetBSD: Makefile,v 1.6 2019/10/04 09:47:28 mrg Exp $
 
 .include <bsd.own.mk>
 
@@ -20,4 +20,6 @@ CPPFLAGS+=-I${IDIST}/include -I${IDIST}/
 
 .PATH: ${DIST}
 
+COPTS.ntp-keygen.c+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-error=restrict :}
+
 .include <bsd.prog.mk>

Index: src/external/bsd/ntp/bin/ntpd/Makefile
diff -u src/external/bsd/ntp/bin/ntpd/Makefile:1.22 src/external/bsd/ntp/bin/ntpd/Makefile:1.23
--- src/external/bsd/ntp/bin/ntpd/Makefile:1.22	Fri Feb  2 01:02:39 2018
+++ src/external/bsd/ntp/bin/ntpd/Makefile	Fri Oct  4 09:47:27 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.22 2018/02/02 01:02:39 mrg Exp $
+#	$NetBSD: Makefile,v 1.23 2019/10/04 09:47:27 mrg Exp $
 
 .include <bsd.own.mk>
 
@@ -92,4 +92,6 @@ YHEADER=1
 COPTS.ntp_control.c+=  -Wno-error=maybe-uninitialized
 .endif
 
+COPTS.ntp_loopfilter.c+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-error=restrict :}
+
 .include <bsd.prog.mk>

Index: src/external/bsd/pkg_install/lib/Makefile
diff -u src/external/bsd/pkg_install/lib/Makefile:1.9 src/external/bsd/pkg_install/lib/Makefile:1.10
--- src/external/bsd/pkg_install/lib/Makefile:1.9	Fri Apr 23 20:56:01 2010
+++ src/external/bsd/pkg_install/lib/Makefile	Fri Oct  4 09:47:28 2019
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.9 2010/04/23 20:56:01 joerg Exp $
+# $NetBSD: Makefile,v 1.10 2019/10/04 09:47:28 mrg Exp $
 # Original from FreeBSD, no rcs id.
 
 LIBISPRIVATE=	yes
@@ -25,4 +25,6 @@ CLEANFILES+=	pkg_install.conf.5
 
 CPPFLAGS+=	-DNETBSD
 
+COPTS.plist.c+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-error=restrict :}
+
 .include <bsd.lib.mk>

Index: src/external/mit/xorg/lib/libXext/Makefile
diff -u src/external/mit/xorg/lib/libXext/Makefile:1.8 src/external/mit/xorg/lib/libXext/Makefile:1.9
--- src/external/mit/xorg/lib/libXext/Makefile:1.8	Sat Jun  1 07:53:11 2013
+++ src/external/mit/xorg/lib/libXext/Makefile	Fri Oct  4 09:47:28 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.8 2013/06/01 07:53:11 mrg Exp $
+#	$NetBSD: Makefile,v 1.9 2019/10/04 09:47:28 mrg Exp $
 
 .include <bsd.own.mk>
 
@@ -100,5 +100,7 @@ INCSDIR=${X11INCDIR}/X11/extensions
 
 PKGDIST=	${LIB}
 
+COPTS.XEVI.c+= ${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-error :}
+
 .include <bsd.x11.mk>
 .include <bsd.lib.mk>

Index: src/usr.bin/tftp/Makefile
diff -u src/usr.bin/tftp/Makefile:1.11 src/usr.bin/tftp/Makefile:1.12
--- src/usr.bin/tftp/Makefile:1.11	Fri Mar 29 18:53:21 2013
+++ src/usr.bin/tftp/Makefile	Fri Oct  4 09:47:28 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.11 2013/03/29 18:53:21 rkujawa Exp $
+#	$NetBSD: Makefile,v 1.12 2019/10/04 09:47:28 mrg Exp $
 #	@(#)Makefile	8.1 (Berkeley) 6/6/93
 
 WARNS?=2
@@ -8,4 +8,6 @@ USE_FORT?= yes	# network client
 PROG=	tftp
 SRCS=	main.c tftp.c tftpsubs.c
 
+COPTS.tftp.c+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-array-bounds :}
+
 .include <bsd.prog.mk>

Index: src/usr.sbin/sysinst/Makefile.inc
diff -u src/usr.sbin/sysinst/Makefile.inc:1.23 src/usr.sbin/sysinst/Makefile.inc:1.24
--- src/usr.sbin/sysinst/Makefile.inc:1.23	Sun Sep 29 23:45:02 2019
+++ src/usr.sbin/sysinst/Makefile.inc	Fri Oct  4 09:47:28 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile.inc,v 1.23 2019/09/29 23:45:02 mrg Exp $
+#	$NetBSD: Makefile.inc,v 1.24 2019/10/04 09:47:28 mrg Exp $
 #
 # Makefile for sysinst
 
@@ -126,6 +126,8 @@ CPPFLAGS+=-DINET6
 COPTS+=-Wno-format-truncation
 .endif
 
+# XXX overlapping strncpy/snprintf buffers!
+COPTS.partman.c+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} == 8:? -Wno-error :}
 
 # Host to ftp from.  Default:
 #	"ftp.NetBSD.org"

Reply via email to