(Cc'ed to source-changed-d@, not source-changes@)
m...@eterna.com.au wrote:

> "Izumi Tsutsui" writes:
> > Module Name:        src
> > Committed By:       tsutsui
> > Date:               Sun Dec 29 22:19:13 UTC 2019
> > 
> > Modified Files:
> >     src/usr.sbin/postinstall: postinstall.in
> > 
> > Log Message:
> > Make sure rc, rc.subr, and rc.shutdown are properly updated.
> > 
> > Currently there is no info which rc* files should be updated
> > or not on upgrade (at least rc.conf and rc.local shouldn't),
> > so put back an explicit list in the postinstall script.
> > "Go for it" by christos@ in PR/54741.
> > 
> > Should be pulled up to netbsd-9.
> thanks for making this less bad.
> i wonder if we can have some system in place where we will
> only update these files if we can check they're unmodified,
> eg, each file would have some hash(es) of known versions,
> and if they're found not to match, fail the 'fix' operation
> and allow the user to update manually.  (this will make it
> trip every time, unfortunately, but this seems less bad 
> than overriding local changes - i've been known to change
> rc and rc.subr for various reasons..)

Maybe we should define which files can be configurable or not
in rc(8) man page?

The visible problem is checkyesnox() in rc.subr was added
in netbsd-8 and src/etc/rc.d/network requires checkyesnox().
I.e. rc.d scripts and rc.subr need to be sync'ed on upgrade.

Anyway maybe we need another PR for this.
Izumi Tsutsui

Reply via email to