On Tue, Jan 07, 2020 at 09:50:42AM +0100, Maxime Villard wrote: > Also unrelated remark: > > + kmutex_t pm_lock /* locks for pm_objs */ > + __aligned(64); /* give lock own cache line */ > > x86 CPUs will soon have 128-byte cache lines, and to ease the upgrade, > it is better to use COHERENCY_UNIT rather than hardcoded values.
I totally agree. However in this instance it looked like it could leave me in dependency hell. I don't have much time left to get my changes in and tested, so left it to come back to some other time. Andrew
