On 13.02.2020 00:58, Joerg Sonnenberger wrote: > On Mon, Feb 10, 2020 at 04:45:35PM +0000, Roy Marples wrote: >> On 09/02/2020 19:21, Joerg Sonnenberger wrote: >>> On Sat, Feb 08, 2020 at 12:17:16PM +0000, Santhosh Raju wrote: >>>> Module Name: src >>>> Committed By: fox >>>> Date: Sat Feb 8 12:17:16 UTC 2020 >>>> >>>> Modified Files: >>>> src/external/bsd/dhcpcd/dist/src: dhcp.c >>>> >>>> Log Message: >>>> external/bsd/dhcpcd: Fix a -Wconversion warning. >>>> >>>> Type cast uint16_t to size_t to prevent implicit type conversion. >>> >>> Seriously? That should not warn and no cast should be used either. >> >> What fix would you recommend then? > > Disable the warning in GCC and fill an upstream PR against it. A > conversion from uint16_t to size_t is value preserving by definition of > the ISO C platform limits. It should never create a warning. > > Joerg >
If we disable warnings in our core software in non-trivial source file for over 4000 lines we will mute more serious issues in a pretty sensitive file. We fixed this warning in upstream dhcpcd. We ship with GCC that is typically 2 major versions behind upstream GCC and this at least discourages handling generic issues directly with upstream and upstream has little interest in reiterating over old branches for corner cases that are generally speaking unimportant. So overall I disagree with the request. Feel free to contribute a patch to GCC or find someone in GCC to fix it (we have no resources to do it on our side) so we can remove the cast.
Description: OpenPGP digital signature