On Fri, 6 Mar 2020, matthew green wrote:

Paul Goyette writes:
On Thu, 5 Mar 2020, Paul Goyette wrote:

also aarch64 has no EXEC_AOUT.

Does aarch64 have COMPAT_NETBSD32?  If so, I will adjust my fix.  (I
built 67 different architectures, including all of the ones that the
releng build cluster is building, and did not have any problems with
aarch64 or any other.)

As near as I can tell, aarch64 sets MACHINE_CPU to "aarch64", so it
will not try to build COMPAT_NETBSD32 due to the following tests in
$SRC/sys/compat/netbsd32/netbsd32.mk

.if ${MACHINE_ARCH} == "x86_64" \
     || ${MACHINE_CPU} == "arm" \
     || ${MACHINE_ARCH} == "sparc64" \
     || (!empty(MACHINE_ARCH:Mmips64*) && !defined(BSD_MK_COMPAT_FILE))
COMPAT_USE_NETBSD32?=yes
.else
COMPAT_USE_NETBSD32?=no
.endif


Perhaps the <<<< line should be changed to "aarch64" instead of "arm" ?

what <<< line? :-)

arm64 should be adde here, yes.  arm should remain -- it's
a fake netbsd32 in that it handles the old 32 bit ABI on
32 bit arm systems, so it's still useful.  we're not able
to support both that and EABI on arm64 currently (not sure
how it would be easy without making it possible to compile
the netbsd32 code twice, since there are additional layout
differences that are difficult to handle without letting
the compiler do it for you.)

sorry, i should have added arm64 here when i was looking
at it but i missed it.

Ooopppsss, forgot to tag the <<< line!

Anyway, I actually fixed it differently, in sys/conf/files
rev 1.1259


+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org   |
+--------------------+--------------------------+-----------------------+

Reply via email to