Date: Tue, 24 Mar 2020 13:27:45 +0100 From: Kamil Rytarowski <n...@gmx.com> Message-ID: <5ec1195a-f1c8-cd46-6a14-ea29da109...@gmx.com>
| I patched it myself only when I reproduced the problems myself. I have no doubt that there's a bug that needs fixing - it is the fix proposed that is wrong. My guess is that most probably it is simply doing nothing useful (no harm, no good either) but I need to confirm that. If it is, the correct fix is simply to delete the line (both times it was changed). If not, there's a more serious problem elsewhere that needs fixing elsewhere (after which the line can be deleted!) | OK. I will do it and please fix it in a better way. Working on it now. I haven't seen the revert yet, when I do I will commit the fix (or a fix, this one is somewhat debatble what is correct, though what is there now is obviously wrong ... but just like the one in question, while wrong, it is, in practice, harmless, at least in any normal use of librump). The fix for this issue needs to wait until the real problem the offending line is there to deal with (if any, which I suspect is not the case) is found. kre