In article <>,
matthew green  <> wrote:
>"Jaromir Dolecek" writes:
>> Module Name: src
>> Committed By:        jdolecek
>> Date:                Wed Jun 24 19:55:25 UTC 2020
>> Modified Files:
>>      src/sys/dev/ic: ibm561.c
>> Log Message:
>> avoid allocating almost 5k struct ibm561data on stack in ibm561_cninit();
>> it's too early for kmem_alloc(), so use static variable in BSS
>this seems particularly wasteful for a driver that won't
>be useful for most systems.
>seems like a candidate for allow-listing instead, and as
>it seems to only be relevant for alpha systems, that have
>a fairly large stack (16K), and this will be called with
>a fairly short call stack.

I agree; the BSS kludge is ugly in general and should only be
used sparingly.


Reply via email to