Module Name:    src
Committed By:   rillig
Date:           Fri Aug 27 17:36:37 UTC 2021

Modified Files:
        src/usr.bin/sdiff: edit.c

Log Message:
sdiff: fix undefined behavior when parsing edit commands

lint says: warning: argument to 'function from <ctype.h>' must be cast
to 'unsigned char', not to 'int' [342]


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/usr.bin/sdiff/edit.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.bin/sdiff/edit.c
diff -u src/usr.bin/sdiff/edit.c:1.4 src/usr.bin/sdiff/edit.c:1.5
--- src/usr.bin/sdiff/edit.c:1.4	Thu Sep  1 07:18:51 2011
+++ src/usr.bin/sdiff/edit.c	Fri Aug 27 17:36:37 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: edit.c,v 1.4 2011/09/01 07:18:51 plunky Exp $	*/
+/*	$NetBSD: edit.c,v 1.5 2021/08/27 17:36:37 rillig Exp $	*/
 /*	$OpenBSD: edit.c,v 1.14 2006/05/25 03:20:32 ray Exp $ */
 
 /*
@@ -76,7 +76,7 @@ eparse(const char *cmd, const char *left
 	char buf[BUFSIZ], *text;
 
 	/* Skip whitespace. */
-	while (isspace((int)(*cmd)))
+	while (isspace((unsigned char)(*cmd)))
 		++cmd;
 
 	text = NULL;

Reply via email to