Module Name:    src
Committed By:   rillig
Date:           Sat Aug 28 19:49:29 UTC 2021

Modified Files:
        src/tests/usr.bin/xlint/lint2: output_sorted.exp
        src/usr.bin/xlint/lint2: main2.c

Log Message:
lint: sort the lint2 diagnostics by symbol name


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/usr.bin/xlint/lint2/output_sorted.exp
cvs rdiff -u -r1.20 -r1.21 src/usr.bin/xlint/lint2/main2.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/usr.bin/xlint/lint2/output_sorted.exp
diff -u src/tests/usr.bin/xlint/lint2/output_sorted.exp:1.1 src/tests/usr.bin/xlint/lint2/output_sorted.exp:1.2
--- src/tests/usr.bin/xlint/lint2/output_sorted.exp:1.1	Sat Aug 28 19:45:18 2021
+++ src/tests/usr.bin/xlint/lint2/output_sorted.exp	Sat Aug 28 19:49:28 2021
@@ -1,12 +1,6 @@
-func7000 used( output_sorted.c(10) ), but not defined
-func7000, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
-func7000, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]
 func0000 used( output_sorted.c(10) ), but not defined
 func0000, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
 func0000, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]
-no_prototype used( output_sorted.c(10) ), but not defined
-no_prototype, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
-no_prototype, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]
 func1000 used( output_sorted.c(10) ), but not defined
 func1000, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
 func1000, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]
@@ -25,3 +19,9 @@ func5000, arg 2 used inconsistently  	ou
 func6000 used( output_sorted.c(10) ), but not defined
 func6000, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
 func6000, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]
+func7000 used( output_sorted.c(10) ), but not defined
+func7000, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
+func7000, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]
+no_prototype used( output_sorted.c(10) ), but not defined
+no_prototype, arg 1 used inconsistently  	output_sorted.c(10)[int]  ::  output_sorted.c(11)[pointer to const char]
+no_prototype, arg 2 used inconsistently  	output_sorted.c(10)[pointer to const char]  ::  output_sorted.c(11)[double]

Index: src/usr.bin/xlint/lint2/main2.c
diff -u src/usr.bin/xlint/lint2/main2.c:1.20 src/usr.bin/xlint/lint2/main2.c:1.21
--- src/usr.bin/xlint/lint2/main2.c:1.20	Sat Aug 28 17:11:19 2021
+++ src/usr.bin/xlint/lint2/main2.c	Sat Aug 28 19:49:28 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: main2.c,v 1.20 2021/08/28 17:11:19 rillig Exp $	*/
+/*	$NetBSD: main2.c,v 1.21 2021/08/28 19:49:28 rillig Exp $	*/
 
 /*
  * Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
 
 #include <sys/cdefs.h>
 #if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: main2.c,v 1.20 2021/08/28 17:11:19 rillig Exp $");
+__RCSID("$NetBSD: main2.c,v 1.21 2021/08/28 19:49:28 rillig Exp $");
 #endif
 
 #include <stdio.h>
@@ -187,8 +187,7 @@ main(int argc, char *argv[])
 	mainused();
 
 	/* perform all tests */
-	/* TODO: sort the names; hashcode order looks chaotic. */
-	symtab_forall(check_name);
+	symtab_forall_sorted(check_name);
 
 	exit(0);
 	/* NOTREACHED */

Reply via email to