Module Name:    src
Committed By:   rillig
Date:           Sun Sep  5 11:42:33 UTC 2021

Modified Files:
        src/tests/usr.bin/xlint/lint1: decl_struct_member.c
            decl_struct_member.exp

Log Message:
tests/lint: document the fixed assertion failure for struct

The change to cgram.y 1.328 from 2021-07-15 didn't fix the crash on
purpose, it was merely a side effect.  The grammar rule that probably
fixed this was that the error handling now skips to the next T_SEMI,
which it didn't do before.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/tests/usr.bin/xlint/lint1/decl_struct_member.c
cvs rdiff -u -r1.9 -r1.10 \
    src/tests/usr.bin/xlint/lint1/decl_struct_member.exp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/usr.bin/xlint/lint1/decl_struct_member.c
diff -u src/tests/usr.bin/xlint/lint1/decl_struct_member.c:1.11 src/tests/usr.bin/xlint/lint1/decl_struct_member.c:1.12
--- src/tests/usr.bin/xlint/lint1/decl_struct_member.c:1.11	Wed Aug 25 22:04:52 2021
+++ src/tests/usr.bin/xlint/lint1/decl_struct_member.c	Sun Sep  5 11:42:32 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: decl_struct_member.c,v 1.11 2021/08/25 22:04:52 rillig Exp $	*/
+/*	$NetBSD: decl_struct_member.c,v 1.12 2021/09/05 11:42:32 rillig Exp $	*/
 # 3 "decl_struct_member.c"
 
 struct multi_attributes {
@@ -77,10 +77,12 @@ struct array_of_bit_fields {
  */
 struct {
 	char a(_)0		/* expect: syntax error '0' */
-}
+
 /*
- * FIXME: adding a semicolon here triggers another assertion:
+ * Before cgram.y 1.328 from 2021-07-15, lint ran into an assertion failure
+ * at the closing semicolon:
  *
  * assertion "t == NOTSPEC" failed in end_type at decl.c:774
  */
+};
 /* expect+1: cannot recover from previous errors */

Index: src/tests/usr.bin/xlint/lint1/decl_struct_member.exp
diff -u src/tests/usr.bin/xlint/lint1/decl_struct_member.exp:1.9 src/tests/usr.bin/xlint/lint1/decl_struct_member.exp:1.10
--- src/tests/usr.bin/xlint/lint1/decl_struct_member.exp:1.9	Wed Aug 25 22:04:52 2021
+++ src/tests/usr.bin/xlint/lint1/decl_struct_member.exp	Sun Sep  5 11:42:32 2021
@@ -5,4 +5,4 @@ decl_struct_member.c(38): warning: empty
 decl_struct_member.c(47): error: syntax error 'unnamed member' [249]
 decl_struct_member.c(72): warning: illegal bit-field type 'array[8] of unsigned int' [35]
 decl_struct_member.c(79): error: syntax error '0' [249]
-decl_struct_member.c(87): error: cannot recover from previous errors [224]
+decl_struct_member.c(89): error: cannot recover from previous errors [224]

Reply via email to