Module Name: src
Committed By: rillig
Date: Tue Sep 14 20:13:03 UTC 2021
Modified Files:
src/sbin: Makefile.inc
src/sbin/fsck_lfs: Makefile
src/sbin/newfs_lfs: Makefile
src/sbin/resize_ffs: Makefile
Log Message:
sbin: enable lint for almost all programs
The programs fsck_lfs and newfs_lfs both trigger a longstanding bug in
lint that is difficult to fix, so ignore them for now.
For resize_ffs, lint thinks that 'struct fs' is incomplete, but GCC and
Clang accept it. Needs further investigation.
To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sbin/Makefile.inc
cvs rdiff -u -r1.22 -r1.23 src/sbin/fsck_lfs/Makefile
cvs rdiff -u -r1.14 -r1.15 src/sbin/newfs_lfs/Makefile
cvs rdiff -u -r1.6 -r1.7 src/sbin/resize_ffs/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sbin/Makefile.inc
diff -u src/sbin/Makefile.inc:1.22 src/sbin/Makefile.inc:1.23
--- src/sbin/Makefile.inc:1.22 Wed Mar 21 05:47:53 2012
+++ src/sbin/Makefile.inc Tue Sep 14 20:13:03 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.inc,v 1.22 2012/03/21 05:47:53 matt Exp $
+# $NetBSD: Makefile.inc,v 1.23 2021/09/14 20:13:03 rillig Exp $
# @(#)Makefile.inc 8.1 (Berkeley) 6/8/93
.include <bsd.own.mk> # for MKDYNAMICROOT definition
@@ -9,3 +9,7 @@ BINDIR?= /sbin
.if (${MKDYNAMICROOT} == "no")
LDSTATIC?= -static
.endif
+
+.if ${MKLINT} != "no" && ${LINT_SUPPORTED:Uyes} == "yes"
+realall: lint
+.endif
Index: src/sbin/fsck_lfs/Makefile
diff -u src/sbin/fsck_lfs/Makefile:1.22 src/sbin/fsck_lfs/Makefile:1.23
--- src/sbin/fsck_lfs/Makefile:1.22 Mon Sep 7 03:19:04 2020
+++ src/sbin/fsck_lfs/Makefile Tue Sep 14 20:13:03 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.22 2020/09/07 03:19:04 mrg Exp $
+# $NetBSD: Makefile,v 1.23 2021/09/14 20:13:03 rillig Exp $
# @(#)Makefile 8.1 (Berkeley) 6/5/93
WARNS?= 3 # XXX: sign-compare issues
@@ -19,4 +19,9 @@ CPPFLAGS+=-I${.CURDIR} -I${FSCK} -DIN_FS
LDADD+=-lutil
DPADD+=${LIBUTIL}
+# As of 2021-09-14, lint does not recognize the types as equal, but it should.
+# vnode.c(104): error: redeclaration of register_vget [27]
+# vnode.h(75): previous declaration of register_vget [260]
+LINT_SUPPORTED= no
+
.include <bsd.prog.mk>
Index: src/sbin/newfs_lfs/Makefile
diff -u src/sbin/newfs_lfs/Makefile:1.14 src/sbin/newfs_lfs/Makefile:1.15
--- src/sbin/newfs_lfs/Makefile:1.14 Mon Sep 7 03:09:53 2020
+++ src/sbin/newfs_lfs/Makefile Tue Sep 14 20:13:03 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.14 2020/09/07 03:09:53 mrg Exp $
+# $NetBSD: Makefile,v 1.15 2021/09/14 20:13:03 rillig Exp $
# @(#)Makefile 8.1 (Berkeley) 6/18/93
WARNS?= 3 # XXX: sign-compare issues
@@ -25,4 +25,9 @@ DPADD+=${LIBPROP}
CPPFLAGS+=-I${FSCK_LFS} -I${FSCK} # -DNDEBUG # -DVERBOSE_BLOCKMAP
+# As of 2021-09-14, lint does not recognize the types as equal, but it should.
+# vnode.c(104): error: redeclaration of register_vget [27]
+# vnode.h(75): previous declaration of register_vget [260]
+LINT_SUPPORTED= no
+
.include <bsd.prog.mk>
Index: src/sbin/resize_ffs/Makefile
diff -u src/sbin/resize_ffs/Makefile:1.6 src/sbin/resize_ffs/Makefile:1.7
--- src/sbin/resize_ffs/Makefile:1.6 Sun May 24 14:41:26 2020
+++ src/sbin/resize_ffs/Makefile Tue Sep 14 20:13:03 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.6 2020/05/24 14:41:26 jmcneill Exp $
+# $NetBSD: Makefile,v 1.7 2021/09/14 20:13:03 rillig Exp $
.include <bsd.own.mk>
@@ -14,4 +14,7 @@ LDADD+= -lutil
.PATH: ${NETBSDSRCDIR}/sys/ufs/ffs
.PATH: ${NETBSDSRCDIR}/sbin/fsck
+# resize_ffs.c(90): error: cannot take size/alignment of incomplete type [143]
+LINT_SUPPORTED= no
+
.include <bsd.prog.mk>
