Module Name: src Committed By: thorpej Date: Fri Nov 5 15:18:18 UTC 2021
Modified Files: src/sys/arch/aarch64/include: signal.h Log Message: Normally, to support COMPAT_NETBSD32 we need to define __HAVE_STRUCT_SIGCONTEXT in order to support the old "sigcontext" style of handlers for 32-bit binaries. However, we only support 32-bit EABI binaries on AArch64, and by happy accident (due to a libc bug introduced in 2006), 32-bit NetBSD EABI binaries never used "sigcontext" style handlers. So, we don't need to carry any of this baggage forward. This addresses the AArch64 case of PR kern/56487. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/arch/aarch64/include/signal.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/arch/aarch64/include/signal.h diff -u src/sys/arch/aarch64/include/signal.h:1.3 src/sys/arch/aarch64/include/signal.h:1.4 --- src/sys/arch/aarch64/include/signal.h:1.3 Wed Oct 27 04:45:42 2021 +++ src/sys/arch/aarch64/include/signal.h Fri Nov 5 15:18:18 2021 @@ -1,4 +1,4 @@ -/* $NetBSD: signal.h,v 1.3 2021/10/27 04:45:42 thorpej Exp $ */ +/* $NetBSD: signal.h,v 1.4 2021/11/05 15:18:18 thorpej Exp $ */ #ifndef _AARCH64_SIGNAL_H_ #define _AARCH64_SIGNAL_H_ @@ -6,8 +6,16 @@ #include <arm/signal.h> #ifdef _KERNEL -/* This is needed to support COMPAT_NETBSD32. */ -#define __HAVE_STRUCT_SIGCONTEXT +/* + * Normally, to support COMPAT_NETBSD32 we need to define + * __HAVE_STRUCT_SIGCONTEXT in order to support the old + * "sigcontext" style of handlers for 32-bit binaries. + * However, we only support 32-bit EABI binaries on AArch64, + * and by happy accident (due to a libc bug introduced in + * 2006), 32-bit NetBSD EABI binaries never used "sigcontext" + * style handlers. So, we don't need to carry any of this + * baggage forward. + */ #endif /* _KERNEL */ #endif /* ! _AARCH64_SIGNAL_H_ */