Module Name: src
Committed By: rillig
Date: Sun Dec 5 15:51:33 UTC 2021
Modified Files:
src/usr.bin/make/unit-tests: varmod-loop-delete.mk
Log Message:
tests/make: document use-after-free in ':@' more precisely
The commit message from the previous commit was misleading. This bug
had not been introduced in 2016.02.27.16.20.06 (which was entirely
unrelated) but rather in 2016.02.18.23.33.25.
The commit 2016.02.27.16.20.06 just happened to be the first one from my
make-archive that triggered the bug. That's because I had only checked
out the last commit from each month, to save some disk space.
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/varmod-loop-delete.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/unit-tests/varmod-loop-delete.mk
diff -u src/usr.bin/make/unit-tests/varmod-loop-delete.mk:1.1 src/usr.bin/make/unit-tests/varmod-loop-delete.mk:1.2
--- src/usr.bin/make/unit-tests/varmod-loop-delete.mk:1.1 Sun Dec 5 15:20:13 2021
+++ src/usr.bin/make/unit-tests/varmod-loop-delete.mk Sun Dec 5 15:51:33 2021
@@ -1,13 +1,13 @@
-# $NetBSD: varmod-loop-delete.mk,v 1.1 2021/12/05 15:20:13 rillig Exp $
+# $NetBSD: varmod-loop-delete.mk,v 1.2 2021/12/05 15:51:33 rillig Exp $
#
# Tests for the variable modifier ':@', which as a side effect allows to
# delete an arbitrary variable.
# A side effect of the modifier ':@' is that the loop variable is created as
# an actual variable in the current evaluation scope (Command/Global/target),
-# and at the end of the loop, this variable is deleted. Before var.c 1.963
-# from 2021-12-05, a variable could be deleted while it was in use, leading to
-# a use-after-free bug.
+# and at the end of the loop, this variable is deleted. Since var.c 1.204
+# from 2016-02-18 and before var.c 1.963 from 2021-12-05, a variable could be
+# deleted while it was in use, leading to a use-after-free bug.
#
# See Var_Parse, comment 'the value of the variable must not change'.
