Module Name:    src
Committed By:   riastradh
Date:           Sun Dec 19 12:08:27 UTC 2021

Modified Files:
        src/sys/external/bsd/drm2/dist/drm/i915/gem: i915_gem_mman.c

Log Message:
i915: Avoid leaking reference count when mapping objects.

We already did i915_gem_object_get_rcu above, which bumps the
reference count; no need to additionally do drm_gem_object_get.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 \
    src/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c
diff -u src/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c:1.14 src/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c:1.15
--- src/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c:1.14	Sun Dec 19 12:08:10 2021
+++ src/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c	Sun Dec 19 12:08:27 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: i915_gem_mman.c,v 1.14 2021/12/19 12:08:10 riastradh Exp $	*/
+/*	$NetBSD: i915_gem_mman.c,v 1.15 2021/12/19 12:08:27 riastradh Exp $	*/
 
 /*
  * SPDX-License-Identifier: MIT
@@ -7,7 +7,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: i915_gem_mman.c,v 1.14 2021/12/19 12:08:10 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: i915_gem_mman.c,v 1.15 2021/12/19 12:08:27 riastradh Exp $");
 
 #include <linux/anon_inodes.h>
 #include <linux/mman.h>
@@ -1077,7 +1077,6 @@ i915_gem_mmap_object(struct drm_device *
 	}
 
 	/* Success!  */
-	drm_gem_object_get(&obj->base);
 	*uobjp = &obj->base.gemo_uvmobj;
 	*uoffsetp = 0;
 	return 0;

Reply via email to