Module Name:    src
Committed By:   knakahara
Date:           Mon Mar  7 04:06:20 UTC 2022

Modified Files:
        src/sys/net: if_spppsubr.c

Log Message:
Don't change ifp->if_link_state directly.  Pointed out by yamaguchi@n.o.


To generate a diff of this commit:
cvs rdiff -u -r1.261 -r1.262 src/sys/net/if_spppsubr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/net/if_spppsubr.c
diff -u src/sys/net/if_spppsubr.c:1.261 src/sys/net/if_spppsubr.c:1.262
--- src/sys/net/if_spppsubr.c:1.261	Mon Oct 25 02:10:56 2021
+++ src/sys/net/if_spppsubr.c	Mon Mar  7 04:06:20 2022
@@ -1,4 +1,4 @@
-/*	$NetBSD: if_spppsubr.c,v 1.261 2021/10/25 02:10:56 knakahara Exp $	 */
+/*	$NetBSD: if_spppsubr.c,v 1.262 2022/03/07 04:06:20 knakahara Exp $	 */
 
 /*
  * Synchronous PPP/Cisco link level subroutines.
@@ -41,7 +41,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_spppsubr.c,v 1.261 2021/10/25 02:10:56 knakahara Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_spppsubr.c,v 1.262 2022/03/07 04:06:20 knakahara Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "opt_inet.h"
@@ -1103,7 +1103,7 @@ sppp_attach(struct ifnet *ifp)
 	if_alloc_sadl(ifp);
 
 	/* Lets not beat about the bush, we know we're down. */
-	ifp->if_link_state = LINK_STATE_DOWN;
+	if_link_state_change(ifp, LINK_STATE_DOWN);
 
 	snprintf(xnamebuf, sizeof(xnamebuf), "%s.wq_cp", ifp->if_xname);
 	sp->wq_cp = sppp_wq_create(sp, xnamebuf,

Reply via email to