Module Name: src
Committed By: gutteridge
Date: Wed Dec 7 05:38:28 UTC 2022
Modified Files:
src/sys/external/bsd/acpica/dist/executer: exsystem.c
Log Message:
exsystem.c: revert ACPI warning about sleep values >10ms
acpica 20220331 introduced the following change:
For the ASL Sleep() operator, issue a warning if the sleep value is
greater than 10 Milliseconds. Quick boottime is important, so warn about
sleeps greater than 10 ms. Distribution Linux kernels reach initrd in 350
ms, so excessive delays should be called out. 10 ms is chosen randomly,
but three of such delays would already make up ten percent of the
boottime.
This can generate many console messages like:
[ 26.055036] ACPI Warning: Firmware issue: Excessive sleep time
(0x0000000000000064 ms > 10 ms) in ACPI Control Method (20220331/exsystem-239)
(60 of them in the latest boot on one older Ivy Bridge laptop.)
This has been reverted upstream and is not present in the next release.
https://github.com/acpica/acpica/commit/df896f452f945d498736c5775d4ee6629df31786
(Also previously reverted in FreeBSD and Linux.)
To generate a diff of this commit:
cvs rdiff -u -r1.1.1.13 -r1.2 \
src/sys/external/bsd/acpica/dist/executer/exsystem.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/external/bsd/acpica/dist/executer/exsystem.c
diff -u src/sys/external/bsd/acpica/dist/executer/exsystem.c:1.1.1.13 src/sys/external/bsd/acpica/dist/executer/exsystem.c:1.2
--- src/sys/external/bsd/acpica/dist/executer/exsystem.c:1.1.1.13 Sat Aug 27 14:02:04 2022
+++ src/sys/external/bsd/acpica/dist/executer/exsystem.c Wed Dec 7 05:38:27 2022
@@ -231,18 +231,6 @@ AcpiExSystemDoSleep (
AcpiExExitInterpreter ();
/*
- * Warn users about excessive sleep times, so ASL code can be improved to
- * use polling or similar techniques.
- */
- if (HowLongMs > 10)
- {
- ACPI_WARNING ((AE_INFO,
- "Firmware issue: Excessive sleep time (0x%8.8X%8.8X ms > 10 ms)"
- " in ACPI Control Method",
- ACPI_FORMAT_UINT64 (HowLongMs)));
- }
-
- /*
* For compatibility with other ACPI implementations and to prevent
* accidental deep sleeps, limit the sleep time to something reasonable.
*/
