> Module Name: src > Committed By: christos > Date: Sat Sep 28 14:24:59 UTC 2024 > > Modified Files: > src/lib/libc/include: extern.h > > Log Message: > need <sys/types.h> for __off_t in gnu11 mode.
Why do we need to use __off_t in particular here? This file is purely internal to libc, right? So surely we can just use the normal off_t type, instead of the internal sys/ansi.h hack which exists to reduce namespace pollution. I think it is better if __off_t itself appears only in sys/ansi.h and the header files that use it to define off_t without polluting the namespace with anything else. (For that matter, not sure why we don't use _BSD_OFF_T_ like _BSD_SIZE_T_.)