Module Name:    src
Committed By:   riastradh
Date:           Fri Nov 22 16:07:10 UTC 2024

Modified Files:
        src/external/public-domain/xz/lib: Makefile lzma.expsym

Log Message:
liblzma: Build with -fvisibility=hidden like upstream.

Intentional exports are marked upstream with
__attribute__((__visibility__("default"))).

This has the effect of deleting symbols, but I'm not bumping the
major right now, and I am considering pullup, because none of the
deleted symbols has ever been declared in the public .h files, so
these symbols can only be used by either (a) reaching into places
applications shouldn't, or (b) accidental namespace collisions.

PR lib/58841: liblzma leaks private symbols

Should fix big-endian builds after recent changes for:

PR lib/58838: shared libraries in base should all have expsym lists


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/external/public-domain/xz/lib/Makefile
cvs rdiff -u -r1.1 -r1.2 src/external/public-domain/xz/lib/lzma.expsym

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/external/public-domain/xz/lib/Makefile
diff -u src/external/public-domain/xz/lib/Makefile:1.11 src/external/public-domain/xz/lib/Makefile:1.12
--- src/external/public-domain/xz/lib/Makefile:1.11	Fri Jul 22 15:43:37 2022
+++ src/external/public-domain/xz/lib/Makefile	Fri Nov 22 16:07:10 2024
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.11 2022/07/22 15:43:37 wiz Exp $
+# $NetBSD: Makefile,v 1.12 2024/11/22 16:07:10 riastradh Exp $
 
 .include <bsd.init.mk>
 
@@ -19,6 +19,8 @@ INCSDIR=	/usr/include/lzma
 LDFLAGS+=	-Wl,-z,defs
 .endif
 
+CFLAGS+=	-fvisibility=hidden
+
 CPPFLAGS+=	-I${XZSRCDIR}/src/common
 CPPFLAGS+=	-I${XZSRCDIR}/src/liblzma/check
 CPPFLAGS+=	-I${XZSRCDIR}/src/liblzma/common

Index: src/external/public-domain/xz/lib/lzma.expsym
diff -u src/external/public-domain/xz/lib/lzma.expsym:1.1 src/external/public-domain/xz/lib/lzma.expsym:1.2
--- src/external/public-domain/xz/lib/lzma.expsym:1.1	Fri Nov 22 02:28:24 2024
+++ src/external/public-domain/xz/lib/lzma.expsym	Fri Nov 22 16:07:10 2024
@@ -1,49 +1,29 @@
-lzma_alloc
-lzma_alloc_zero
 lzma_alone_decoder
-lzma_alone_decoder_init
 lzma_alone_encoder
 lzma_auto_decoder
 lzma_block_buffer_bound
-lzma_block_buffer_bound64
 lzma_block_buffer_decode
 lzma_block_buffer_encode
 lzma_block_compressed_size
 lzma_block_decoder
-lzma_block_decoder_init
 lzma_block_encoder
-lzma_block_encoder_init
 lzma_block_header_decode
 lzma_block_header_encode
 lzma_block_header_size
 lzma_block_total_size
 lzma_block_uncomp_encode
 lzma_block_unpadded_size
-lzma_bufcpy
-lzma_check_finish
-lzma_check_init
 lzma_check_is_supported
 lzma_check_size
-lzma_check_update
 lzma_code
 lzma_cputhreads
 lzma_crc32
-lzma_crc32_table
 lzma_crc64
-lzma_crc64_table
-lzma_delta_coder_init
-lzma_delta_coder_memusage
-lzma_delta_decoder_init
-lzma_delta_encoder_init
-lzma_delta_props_decode
-lzma_delta_props_encode
 lzma_easy_buffer_encode
 lzma_easy_decoder_memusage
 lzma_easy_encoder
 lzma_easy_encoder_memusage
-lzma_easy_preset
 lzma_end
-lzma_fastpos
 lzma_filter_decoder_is_supported
 lzma_filter_encoder_is_supported
 lzma_filter_flags_decode
@@ -51,11 +31,8 @@ lzma_filter_flags_encode
 lzma_filter_flags_size
 lzma_filters_copy
 lzma_filters_update
-lzma_footer_magic
-lzma_free
 lzma_get_check
 lzma_get_progress
-lzma_header_magic
 lzma_index_append
 lzma_index_block_count
 lzma_index_buffer_decode
@@ -65,7 +42,6 @@ lzma_index_checks
 lzma_index_decoder
 lzma_index_dup
 lzma_index_encoder
-lzma_index_encoder_init
 lzma_index_end
 lzma_index_file_size
 lzma_index_hash_append
@@ -80,8 +56,6 @@ lzma_index_iter_next
 lzma_index_iter_rewind
 lzma_index_memusage
 lzma_index_memused
-lzma_index_padding_size
-lzma_index_prealloc
 lzma_index_size
 lzma_index_stream_count
 lzma_index_stream_flags
@@ -89,96 +63,26 @@ lzma_index_stream_padding
 lzma_index_stream_size
 lzma_index_total_size
 lzma_index_uncompressed_size
-lzma_lz_decoder_init
-lzma_lz_decoder_memusage
-lzma_lz_decoder_uncompressed
-lzma_lz_encoder_init
-lzma_lz_encoder_memusage
-lzma_lzma2_block_size
-lzma_lzma2_decoder_init
-lzma_lzma2_decoder_memusage
-lzma_lzma2_encoder_init
-lzma_lzma2_encoder_memusage
-lzma_lzma2_props_decode
-lzma_lzma2_props_encode
-lzma_lzma_decoder_create
-lzma_lzma_decoder_init
-lzma_lzma_decoder_memusage
-lzma_lzma_decoder_memusage_nocheck
-lzma_lzma_encode
-lzma_lzma_encoder_create
-lzma_lzma_encoder_init
-lzma_lzma_encoder_memusage
-lzma_lzma_encoder_reset
-lzma_lzma_lclppb_decode
-lzma_lzma_lclppb_encode
-lzma_lzma_optimum_fast
-lzma_lzma_optimum_normal
 lzma_lzma_preset
-lzma_lzma_props_decode
-lzma_lzma_props_encode
 lzma_memlimit_get
 lzma_memlimit_set
 lzma_memusage
-lzma_mf_bt2_find
-lzma_mf_bt2_skip
-lzma_mf_bt3_find
-lzma_mf_bt3_skip
-lzma_mf_bt4_find
-lzma_mf_bt4_skip
-lzma_mf_find
-lzma_mf_hc3_find
-lzma_mf_hc3_skip
-lzma_mf_hc4_find
-lzma_mf_hc4_skip
 lzma_mf_is_supported
 lzma_mode_is_supported
-lzma_mt_block_size
-lzma_next_end
-lzma_next_filter_init
-lzma_next_filter_update
-lzma_outq_end
-lzma_outq_get_buf
-lzma_outq_init
-lzma_outq_is_readable
-lzma_outq_memusage
-lzma_outq_read
 lzma_physmem
 lzma_properties_decode
 lzma_properties_encode
 lzma_properties_size
 lzma_raw_buffer_decode
 lzma_raw_buffer_encode
-lzma_raw_coder_init
-lzma_raw_coder_memusage
 lzma_raw_decoder
-lzma_raw_decoder_init
 lzma_raw_decoder_memusage
 lzma_raw_encoder
-lzma_raw_encoder_init
 lzma_raw_encoder_memusage
-lzma_rc_prices
-lzma_simple_arm_decoder_init
-lzma_simple_arm_encoder_init
-lzma_simple_armthumb_decoder_init
-lzma_simple_armthumb_encoder_init
-lzma_simple_coder_init
-lzma_simple_ia64_decoder_init
-lzma_simple_ia64_encoder_init
-lzma_simple_powerpc_decoder_init
-lzma_simple_powerpc_encoder_init
-lzma_simple_props_decode
-lzma_simple_props_encode
-lzma_simple_props_size
-lzma_simple_sparc_decoder_init
-lzma_simple_sparc_encoder_init
-lzma_simple_x86_decoder_init
-lzma_simple_x86_encoder_init
 lzma_stream_buffer_bound
 lzma_stream_buffer_decode
 lzma_stream_buffer_encode
 lzma_stream_decoder
-lzma_stream_decoder_init
 lzma_stream_encoder
 lzma_stream_encoder_mt
 lzma_stream_encoder_mt_memusage
@@ -187,9 +91,6 @@ lzma_stream_footer_decode
 lzma_stream_footer_encode
 lzma_stream_header_decode
 lzma_stream_header_encode
-lzma_strm_init
-lzma_tuklib_cpucores
-lzma_tuklib_physmem
 lzma_version_number
 lzma_version_string
 lzma_vli_decode

Reply via email to